Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refectoring and improvements #508

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Refectoring and improvements #508

merged 2 commits into from
Feb 15, 2024

Conversation

pvital
Copy link
Member

@pvital pvital commented Feb 15, 2024

This PR contains two commits to refector and improve our code:

  1. The first guarantee container images always come from the Docker registry. That prevents that podman, for example, running in RHEL systems, from downloading images from other registries.
  2. To reduce the maintenance of the requirements used in our tests, this fix refers to other requirement files that have the same list of packages.

Signed-off-by: Paulo Vital [email protected]

To reduce the maintenance of the requirements used in our tests, this fix refer other requirement files that have the same list of packages.

Signed-off-by: Paulo Vital <[email protected]>
@pvital pvital self-assigned this Feb 15, 2024
@pvital pvital requested review from Ferenc- and GSVarsha February 15, 2024 07:12
Copy link
Collaborator

@Ferenc- Ferenc- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pvital pvital merged commit 5c7262e into master Feb 15, 2024
12 checks passed
@pvital pvital deleted the refectoring branch February 15, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants