Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance boto3 instrumentation to capture HTTP headers in all four flavours #499

Merged
merged 12 commits into from
Feb 7, 2024
Merged

Enhance boto3 instrumentation to capture HTTP headers in all four flavours #499

merged 12 commits into from
Feb 7, 2024

Conversation

GSVarsha
Copy link
Contributor

What

Enhance boto3 instrumentation to capture HTTP headers in all four flavours

Signed-off-by: Varsha GS [email protected]

References

Why

According to our spec, tracers SHOULD capture all four flavours of HTTP headers.

@GSVarsha GSVarsha self-assigned this Jan 29, 2024
@GSVarsha GSVarsha added enhancement wip work in progress labels Jan 29, 2024
@GSVarsha GSVarsha requested review from pvital and Ferenc- January 29, 2024 10:44
@GSVarsha GSVarsha mentioned this pull request Jan 29, 2024
Closed
Ferenc-
Ferenc- requested changes Jan 29, 2024
View reviewed changes
Copy link
Collaborator

@Ferenc- Ferenc- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The request header extraction should either focus on headers that paricipate in the HTTP call, or should be omitted.

@GSVarsha GSVarsha requested a review from Ferenc- January 31, 2024 11:17
Ferenc-
Ferenc- requested changes Jan 31, 2024
View reviewed changes
Copy link
Collaborator

@Ferenc- Ferenc- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want pursue the extraction from request headers, then we should ensure that it works when the headers are added with event_system.register_first('before-sign.s3.CreateBucket', _add_header).

Ferenc-
Ferenc- approved these changes Feb 1, 2024
View reviewed changes
Copy link
Collaborator

@Ferenc- Ferenc- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very well done! Hats off.

@GSVarsha GSVarsha marked this pull request as ready for review February 6, 2024 12:03
@GSVarsha GSVarsha closed this Feb 6, 2024
@GSVarsha GSVarsha reopened this Feb 6, 2024
@GSVarsha
boto3_s3: capture req and res HTTPHeaders
9f6c368 
Signed-off-by: Varsha GS <[email protected]>
@GSVarsha
refactor(test_boto3_s3): use unittest.TestCase class and respective a…
6c78140 
…ssert statements

Signed-off-by: Varsha GS <[email protected]>
@GSVarsha
add custom headers to before-call and access them in request-created
05a66e1 
Signed-off-by: Varsha GS <[email protected]>
@GSVarsha
adapt to both before-call and before-sign
162dbe1 
Signed-off-by: Varsha GS <[email protected]>
@GSVarsha
add separate TCs for before-call and before-sign
7703517 
Signed-off-by: Varsha GS <[email protected]>
@GSVarsha
boto3: test capture headers feature for secretsmanager, ses, sqs
5b06fe4 
Signed-off-by: Varsha GS <[email protected]>
@GSVarsha
boto3: test lambda invoke method
80c38f1 
Signed-off-by: Varsha GS <[email protected]>
@GSVarsha
boto3: setting use_docker to false
f0f2a75 
Signed-off-by: Varsha GS <[email protected]>
@GSVarsha
capture headers for lambda
09f51b6 
Signed-off-by: Varsha GS <[email protected]>
@GSVarsha GSVarsha force-pushed the enhance-boto3-instrumentation branch from 89d519c to 06268d2 Compare February 6, 2024 12:29
@GSVarsha GSVarsha requested a review from Ferenc- February 6, 2024 12:49
@GSVarsha
minor fixes
0902f06 
Signed-off-by: Varsha GS <[email protected]>
@Ferenc- Ferenc- merged commit fa2e561 into master Feb 7, 2024
12 checks passed
@Ferenc- Ferenc- deleted the enhance-boto3-instrumentation branch February 7, 2024 10:39
@GSVarsha GSVarsha removed the wip work in progress label Feb 7, 2024
@GSVarsha GSVarsha added this to the H1-2024 milestone Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ferenc- Ferenc- Ferenc- approved these changes

@pvital pvital Awaiting requested review from pvital

Assignees

@GSVarsha GSVarsha

Labels
enhancement
Projects
None yet
Milestone
H1-2024
Development

Successfully merging this pull request may close these issues.
2 participants
@GSVarsha @Ferenc-