Informix Db: Parameterized Sql Trace via configuration #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdb/config/config-informix.yaml
Outdated
| @@ -33,6 +33,7 @@ instances: | |||
| #Time Frame for which you want to get the expensive query. Default value 900 Sec | |||
| db.sql.elapsed.timeframe: 900 # Values should be in Seconds | |||
| db.sequential.scan.count: 0 | |||
| db.sql.trace.enabled: 0 # Value should be 0 if the SQL Trace is enabled and 1 when not eneabled.When not specified, SQL Trace is considered to be disabled. | |||
There was a problem hiding this comment.
it should be a boolean value.
Suggested change
| db.sql.trace.enabled: 0 # Value should be 0 if the SQL Trace is enabled and 1 when not eneabled.When not specified, SQL Trace is considered to be disabled. | |
| db.sql.trace.enabled: false #Default is false. Make it true only if `SqlTrace` is enabled for the DB. |
rdb/src/main/java/com/instana/dc/rdb/impl/informix/InformixDc.java
Outdated
Show resolved
Hide resolved
rdb/src/main/java/com/instana/dc/rdb/impl/informix/InformixDc.java
Outdated
Show resolved
Hide resolved
rdb/src/main/java/com/instana/dc/rdb/impl/informix/InformixDc.java
Outdated
Show resolved
Hide resolved
| @@ -65,6 +66,8 @@ public class InformixDc extends AbstractDbDc { | |||
|
|
|||
| private final MetricsCollector metricCollector; | |||
|
|
|||
| public boolean sqlTraceEnabled; | |||
There was a problem hiding this comment.
Do you need it to be public? I don't see you are using it anywhere outside this class.
Suggested change
| public boolean sqlTraceEnabled; | |
| private boolean isSqlTraceEnabled; |
| @@ -289,11 +293,13 @@ private void getallMetrics() { | |||
|
|
|||
| @SuppressWarnings("unchecked") | |||
| private void mediumPollingInterval() { | |||
| getRawMetric(DB_SQL_COUNT_NAME).setValue((Number) metricCollector.collectMetrics(DB_SQL_COUNT_NAME)); | |||
| if(sqlTraceEnabled==true) { | |||
There was a problem hiding this comment.
it is boolean attribute why do you need == true
debnathbikram
changed the title
added 2 commits
July 10, 2024 15:17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A parameter to specify whether SQL Tracing for Informix DB is enabled is added in the Configuration