Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Currency Bot] Bumped graphql-subscriptions from 2.0.0 to 3.0.0 #1446

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

instanacd
Copy link
Contributor

Tada!

@instanacd instanacd requested a review from a team as a code owner November 12, 2024 18:24
@abhilash-sivan
Copy link
Contributor

abhilash-sivan commented Nov 13, 2024

A major code change has affected our instrumentation. We might have to support both v2.0.0 and v3.0.0 separately. We can discuss it internally.

https://github.com/apollographql/graphql-subscriptions/releases

Replaced iterall with native Symbol.asyncIterator. PubSubEngine.asyncIterator is now PubSubEngine.asyncIterableIterator

@abhilash-sivan abhilash-sivan force-pushed the currency-bot-major-graphqlsubscriptions branch from 0c3c616 to bc62393 Compare November 13, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants