Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support additional volume and mounts #229

Merged
merged 4 commits into from
Jan 7, 2025
Merged

feat: support additional volume and mounts #229

merged 4 commits into from
Jan 7, 2025

Conversation

boonware
Copy link
Collaborator

@boonware boonware commented Dec 3, 2024

@boonware boonware marked this pull request as ready for review December 3, 2024 10:44
@boonware boonware requested a review from a team as a code owner December 3, 2024 10:44
Copy link
Contributor

@konrad-ohms konrad-ohms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, could you please add an example usage to https://github.com/instana/instana-agent-operator/blob/main/config/samples/instana_v1_extended_instanaagent.yaml ?
We try to keep examples in the repo for easy exploration of options on the CR.

I tried with a simple emtpydir for now:

...
    pod:
      volumeMounts:
      - mountPath: /cache
        name: cache-volume
      volumes:
      - emptyDir:
          sizeLimit: 500Mi
        name: cache-volume
...

I guess we would want to include an example how to mount a secret or a configmap.
A secret might make the most sense as we want to use it to mount trust stores and certificates.

It would also be great if you could add an end-to-end test in https://github.com/instana/instana-agent-operator/tree/main/e2e, but I couls also help out here, whatever you prefer 🙂 .

@boonware boonware force-pushed the 4619 branch 2 times, most recently from 54cbc13 to e1d09e5 Compare December 3, 2024 14:43
boonware and others added 4 commits December 11, 2024 12:22
Signed-off-by: J. Harte <[email protected]>
Signed-off-by: J. Harte <[email protected]>
Signed-off-by: J. Harte <[email protected]>
Signed-off-by: J. Harte <[email protected]>
Signed-off-by: J. Harte <[email protected]>
Signed-off-by: J. Harte <[email protected]>
Signed-off-by: J. Harte <[email protected]>
Copy link
Contributor

@konrad-ohms konrad-ohms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, look good

Comment on lines +108 to +114
volumes:
- name: my-secret-volume
secret:
secretName: instana-agent-key
volumeMounts:
- name: my-secret-volume
mountPath: /secrets
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When having a final look, I noticed that this is actually the extended_instanaagent.yaml which shows all available options, but typically just defines the defaults.
Your changes are adding new volumes which would not reflect the default behavior, so probably it would be more consistent to have your values in that file as comment and use a separate file for the test input.
But I also realized that your e2e test is relying on the given yaml to mount the secret, so I am fine for leaving it in as is for now, I might move the test input into a new file eventually, but that should not block the release for now.

@konrad-ohms konrad-ohms merged commit 4f7afca into main Jan 7, 2025
8 checks passed
@konrad-ohms konrad-ohms deleted the 4619 branch January 7, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants