Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker test: check detached container #337

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Docker test: check detached container #337

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
338fa27
Docker test: check detached container
ael-code Jan 21, 2018
b9436b6
docker test: Fix indentation
ael-code Jan 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions .docker/test_all.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,22 @@ function test_libreant_search {
curl -fs "localhost:5000/search?q=*:*" > /dev/null
}

function check_detatched_container {
c_name=$1
running=`docker container inspect $c_name --format={{.State.Running}}`
if [ "$running" == "false" ]; then
echo -e "\nERROR: container '$c_name' is not running." 1>&2
echo "Container state: " 1>&2
docker container inspect $c_name --format=" Status: {{.State.Status}}" 1>&2
docker container inspect $c_name --format=" ExitCode: {{.State.ExitCode}}" 1>&2
echo "Container's log tail:" 1>&2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saxon genitive is for people only, not for things. Container last log lines: would be better

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

docker logs --tail=10 $c_name
return 1
fi
return 0
}


# this implements a linear backoff
# it will wait 1, then 2, then... $CURL_RETRIES seconds
function with_backoff {
Expand Down Expand Up @@ -82,8 +98,9 @@ i=1
for os in "${OSES[@]}" ; do
echo "Testing libreant installation on ${os}"
docker build --file="${LIBREANT_SRC}/.docker/dockerfile-${os}" --tag="${PREFIX}${os}" "${LIBREANT_SRC}"
docker run --rm -p 5000:5000 -d --name "${PREFIX}${os}" "${PREFIX}${os}"
if ! with_backoff test_libreant_homepage; then
docker run -p 5000:5000 -d --name "${PREFIX}${os}" "${PREFIX}${os}"
check_detatched_container "${PREFIX}${os}" || exit 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong indentation?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeap there was various indentation errors. Fixed

if ! with_backoff test_libreant_homepage; then
echo "Failed docker test $i/${#OSES[@]}: $os" >&2
echo "at step 1 (home page)" >&2
docker kill "${PREFIX}${os}"
Expand Down