Skip to content

[skip vbump] initial release v0.1.0#79

Open
donyunardi wants to merge 9 commits into
mainfrom
release-candidate-v0.1.0
Open

[skip vbump] initial release v0.1.0#79
donyunardi wants to merge 9 commits into
mainfrom
release-candidate-v0.1.0

Conversation

@donyunardi
Copy link
Copy Markdown
Contributor

Fix #51

@donyunardi
Copy link
Copy Markdown
Contributor Author

Hi @osenan if you have an ORCID number, feel free to add it to DESCRIPTION.

@donyunardi donyunardi added the core label May 7, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

Unit Tests Summary

  1 files   11 suites   18s ⏱️
275 tests 261 ✅ 14 💤 0 ❌
409 runs  394 ✅ 15 💤 0 ❌

Results for commit 328f88e.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
badge_dropdown 💀 $0.16$ $-0.16$ $-1$ $-1$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
assertion 👶 $+0.02$ unnamed
badge_dropdown 💀 $0.16$ $-0.16$ shinytest2_badge_dropdown_is_visible_when_clicking_on_it_multiple_times

Results for commit 432fac8

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

badge

Code Coverage Summary

Filename                  Stmts    Miss  Cover    Missing
----------------------  -------  ------  -------  --------------------------------------------------------------
R/as_picks.R                140      21  85.00%   64, 168-172, 183-187, 202-208, 230-232
R/assertion.R                 5       0  100.00%
R/call_utils.R              147      22  85.03%   23-28, 65, 132-138, 261, 281-282, 285-289, 294
R/helpers.R                   9       0  100.00%
R/interaction.R              42       1  97.62%   105
R/module_merge.R            257       2  99.22%   328, 609
R/module_picks.R            324      23  92.90%   76-82, 101, 138-139, 328-330, 332-336, 474, 522, 560, 572, 580
R/picks.R                   183       1  99.45%   339
R/print.R                    36       2  94.44%   50, 58
R/resolver.R                141      15  89.36%   110-118, 284-289
R/tidyselect-helpers.R       29       0  100.00%
R/tm_merge.R                 54       0  100.00%
R/ui_containers.R            55       0  100.00%
R/zzz.R                       5       5  0.00%    3-11
TOTAL                      1427      92  93.55%

Diff against main

Filename            Stmts    Miss  Cover
----------------  -------  ------  -------
R/module_picks.R       +1       0  +0.02%
TOTAL                  +1       0  +0.00%

Results for commit: 328f88e

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Copy Markdown
Contributor

@osenan osenan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check locally the suggestion so spaces are correctly placed. I do not trust the suggestion editor here for adding suggestions to the DESCRIPTION.

Comment thread DESCRIPTION Outdated
@donyunardi
Copy link
Copy Markdown
Contributor Author

@osenan to be consistent, I just use usethis::use_tidy_description.

donyunardi and others added 2 commits May 8, 2026 11:14
# Pull Request

> Thanks,
> 
> Please add \value to .Rd files regarding exported methods and explain
> the functions results in the documentation. Please write about the
> structure of the output (class) and also what the output means. (If a
> function does not return a value, please document that too, e.g.
> \value{No return value, called for side effects} or similar)
> For more details:
>
<https://contributor.r-project.org/cran-cookbook/docs_issues.html#missing-value-tags-in-.rd-files>
> 
> -> Missing Rd-tags:
>       as.picks.Rd: \value
>       dot-is_delayed.Rd: \value
>       picks.Rd: \value
>       ranged.Rd: \value
>       tidyselectors.Rd: \value
>       tm_merge.Rd: \value
> 
> Please fix and resubmit.
> 
> Best,
> Konstanze Lauseker (she/her)

---------

Co-authored-by: Oriol Senan <35930244+osenan@users.noreply.github.com>
@averissimo
Copy link
Copy Markdown
Contributor

@donyunardi comments have been fixed and merged to this branch.

All of the information below is for future reference:

IIRC, non-exported functions shouldn't have examples and we learned that in a previous submission with human review.

I think it came down to the need of <package_name>:::<non-exported_function(...) (tripple colon) on the examples and that was not accepted by CRAN (I can't find the communication, maybe you or @gogonzo have it).

Anyway, here are the PR associated with this effort to remove examples insightsengineering/teal.slice#548 insightsengineering/teal#1084 and insightsengineering/teal.modules.general#680

Before merging I discussed this with @llrs-roche to better understand official policy and this seems to be a gray area. If need be we can change from #' @keywords internal to #' @noRd, although I hope it doesn't come to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CRAN Release]: 0.1.0

3 participants