[skip vbump] initial release v0.1.0#79
Conversation
|
Hi @osenan if you have an ORCID number, feel free to add it to DESCRIPTION. |
Unit Tests Summary 1 files 11 suites 18s ⏱️ Results for commit 328f88e. ♻️ This comment has been updated with latest results. |
Unit Test Performance Difference
Additional test case details
Results for commit 432fac8 ♻️ This comment has been updated with latest results. |
Code Coverage SummaryDiff against mainResults for commit: 328f88e Minimum allowed coverage is ♻️ This comment has been updated with latest results |
osenan
left a comment
There was a problem hiding this comment.
Please check locally the suggestion so spaces are correctly placed. I do not trust the suggestion editor here for adding suggestions to the DESCRIPTION.
Co-authored-by: Oriol Senan <35930244+osenan@users.noreply.github.com>
|
@osenan to be consistent, I just use |
# Pull Request
> Thanks,
>
> Please add \value to .Rd files regarding exported methods and explain
> the functions results in the documentation. Please write about the
> structure of the output (class) and also what the output means. (If a
> function does not return a value, please document that too, e.g.
> \value{No return value, called for side effects} or similar)
> For more details:
>
<https://contributor.r-project.org/cran-cookbook/docs_issues.html#missing-value-tags-in-.rd-files>
>
> -> Missing Rd-tags:
> as.picks.Rd: \value
> dot-is_delayed.Rd: \value
> picks.Rd: \value
> ranged.Rd: \value
> tidyselectors.Rd: \value
> tm_merge.Rd: \value
>
> Please fix and resubmit.
>
> Best,
> Konstanze Lauseker (she/her)
---------
Co-authored-by: Oriol Senan <35930244+osenan@users.noreply.github.com>
|
@donyunardi comments have been fixed and merged to this branch. All of the information below is for future reference: IIRC, non-exported functions shouldn't have examples and we learned that in a previous submission with human review. I think it came down to the need of Anyway, here are the PR associated with this effort to remove examples insightsengineering/teal.slice#548 insightsengineering/teal#1084 and insightsengineering/teal.modules.general#680 Before merging I discussed this with @llrs-roche to better understand official policy and this seems to be a gray area. If need be we can change from |
Fix #51