Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix LLaMA 3.2, add clean_special_chars #289

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Fix LLaMA 3.2, add clean_special_chars #289

merged 2 commits into from
Oct 15, 2024

Conversation

gsarti
Copy link
Member

@gsarti gsarti commented Oct 15, 2024 •
edited
Loading

Description

This PR fixes support for multi-EOS models (e.g. LLaMA 3.2, closes #287) and adds a new clean_special_chars: bool = False argument to model.attribute to support the cleaning of special characters from tokens in the out.source and out.target sequences using the native tokenizer.decode function provided by transformers.

Also adds GraniteForCausalLM, GraniteMoeForCausalLM and OlmoeForCausalLM to the model config.

@gsarti gsarti merged commit d7c5269 into main Oct 15, 2024
3 checks passed
@gsarti gsarti deleted the clean-char-llama-32 branch October 15, 2024 15:37
@gsarti gsarti mentioned this pull request Oct 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Model LLaMA 3.2 not suported
1 participant
@gsarti