prep_aria: support for ARIA product v3 correction layers

[sssangha]

Description of proposed changes

Reminders

• Fix #xxxx
• Pass Pre-commit check (green)
• Pass Codacy code review (green)
• Pass Circle CI test (green)
• Make sure that your code follows our style. Use the other functions/files as a basis.
• If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.
• If adding new functionality, add a detailed description to the documentation and/or an example.

[dbekaert]

@sssangha @yunjunz Can we move this PR along? Any updated needed @yunjunz?

[yunjunz]

Thank you @sssangha and @mgovorcin for the PR. Besides the comments above, could you also fix the suggestions from pre-commit and codacy checking?

[yunjunz]

@sssangha @dbekaert I have made some suggestions for this PR. It would be great if it can be updated and moved forward.

[codeautopilot]

PR summary

This pull request introduces support for ARIA product version 3 correction layers in the prep_aria script. The changes include the ability to load and process correction layers such as troposphere, ionosphere, and solid earth tides. The script now supports updated epoch stacks and handles multiple troposphere files. The modifications also include improvements to the command-line interface and examples, as well as code refactoring to reduce maintenance burden by reusing existing functions. The impact of these changes is an enhanced capability to process ARIA data with correction layers, improving the accuracy and usability of the data for users.

Suggestion

Consider adding unit tests to verify the functionality of the new features, especially the handling of multiple troposphere files and the processing of correction layers. This will help ensure the robustness of the changes and facilitate future maintenance. Additionally, updating the documentation to reflect the new capabilities and usage examples would be beneficial for users.

Disclaimer: This comment was entirely generated using AI. Be aware that the information provided may be incorrect.

Current plan usage: 0.00%

Have feedback or need help?
Discord
Documentation
[email protected]

[EJFielding]

I hope this addition can be completed soon. We can really use this ionospheric layer support to advance our NISAR Calibration and Validation activities that use ARIA S1-GUNW files.

[mgovorcin]

do we still need arguments for dask cluster and num-workers as network inversion of iono stack should be outside of this script. Please check, if it is not used, remove

[mgovorcin]

remove this comment, as prep_aria will skip network inversion of iono stack

[mgovorcin]

All @yunjunz suggestions have been addressed, @ehavazli or @rzinke please remove unused args from cli/prep_aria.py before the merge.

[yunjunz]

All @yunjunz suggestions have been addressed, please remove unused args from cli/prep_aria.py before the merge.

Great. I tried to test it last week, but the environment needs to be updated for the new ARIA-tools. I will try it again this weekend.

[EJFielding]

We found recently that the conda-forge ARIA-tools requires Python 3.12 but ISCE2 only allows versions up to 3.11, so it is not presently possible to make a conda environment with ISCE2, ARIA-tools, and MintPy.

[yunjunz]

Thanks for the heads-up @EJFielding, I will create a new env for this test then.

[ehavazli]

Hi @yunjunz and @EJFielding, what's the current status of this PR on your end?

[yunjunz]

Hi @yunjunz and @EJFielding, what's the current status of this PR on your end?

I won't have time to test the change in the coming few days. Since the PR only changes code in prep_aria, it's fine with me to merge as long as others confirm it works. @EJFielding ?