Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: separately import solid functions in storybook examples #997

Closed
wants to merge 1 commit into from
Closed

fix: separately import solid functions in storybook examples #997

wants to merge 1 commit into from

Conversation

vanmarino
Copy link

This PR fixes #790 .

  • I've added a unit test to test for potential regressions of this bug.
  • The changelog has been updated, if applicable.
  • Commits in this PR are minimal and have descriptive commit messages.

@vanmarino vanmarino requested a review from a team as a code owner July 29, 2024 10:49
@vercel Vercel
Copy link

vercel bot commented Jul 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
solid-ui-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2024 10:50am

@NSeydoux NSeydoux mentioned this pull request Aug 14, 2024
Merged
@NSeydoux
Copy link
Contributor

NSeydoux commented Aug 14, 2024 •
edited
Loading

Thanks for fixing this issue @rottier!

This PR is being reapplied in #998 for CI to run

@NSeydoux NSeydoux closed this Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Storybook Provider and Component examples broken
2 participants
@vanmarino @NSeydoux