Fix explorer crash when proving transaction & enhance mithril-client error #1800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlachaume
approved these changes
Jul 4, 2024
Before it would replace the whole text with "Unhandled error
{status_code}", loosing potential details on the error sent by the
aggregator.
It was due to showing the `TransactionCertificationResult` before a certificate could even be retrieved, leading to a `t is undefined` error.
Alenar
force-pushed
the
djo/1784/explorer_doenst_handle_wasm_errors
branch
from
58ae5fd
to
2a71dc1
Compare
* Mithril-client from `0.8.5` to `0.8.6` * Mithril-client-wasm from `0.3.5` to `0.3.6` * Mithril-explorer from `0.7.2` to `0.7.3`
Alenar
force-pushed
the
djo/1784/explorer_doenst_handle_wasm_errors
branch
from
2a71dc1
to
09f0cad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR includes:
Fix explorer crash when an error is returned when proving transaction (Explorer does not handle invalid transaction hashes #1784)
Enhance error transmission from the
mithril-clientwhen the queried aggregator return a 4xx or a 5xx error.Pre-submit checklist
Issue(s)
Closes #1784