Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional embedding cardano cli in docker image #1789

Merged

Conversation

sfauvel
Copy link
Collaborator

@sfauvel sfauvel commented Jun 28, 2024

Content

By default, build docker images (aggregator and signer) without Cardano CLI which is useless when using Pallas.

We can embed it setting to 1 the build arg EMBED-CARDANO-CLI.

Example:
docker build -t mithril/mithril-aggregator --build-arg EMBED-CARDANO-CLI=1 -f mithril-aggregator/Dockerfile .

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Issue(s)

Closes 1725

Copy link

github-actions bot commented Jun 28, 2024

Test Results

    4 files  ±0     51 suites  ±0   8m 54s ⏱️ +6s
1 101 tests ±0  1 101 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 249 runs  ±0  1 249 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 4e6e69f. ± Comparison against base commit ed03ede.

♻️ This comment has been updated with latest results.

@sfauvel sfauvel temporarily deployed to testing-sanchonet June 28, 2024 12:07 — with GitHub Actions Inactive
@sfauvel sfauvel changed the title sfa/1725/conditional embedding cardano cli in docker image Conditional embedding cardano cli in docker image Jun 28, 2024
@sfauvel sfauvel temporarily deployed to testing-sanchonet June 28, 2024 14:15 — with GitHub Actions Inactive
@sfauvel sfauvel force-pushed the sfa/1725/conditional_embedding_cardano_cli_in_docker_image branch from b648bd0 to 3da4c38 Compare June 28, 2024 14:50
@sfauvel sfauvel temporarily deployed to testing-sanchonet June 28, 2024 14:57 — with GitHub Actions Inactive
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfauvel sfauvel force-pushed the sfa/1725/conditional_embedding_cardano_cli_in_docker_image branch from 2e6765d to 4e6e69f Compare July 1, 2024 13:42
@sfauvel sfauvel temporarily deployed to testing-sanchonet July 1, 2024 13:49 — with GitHub Actions Inactive
@sfauvel sfauvel temporarily deployed to testing-sanchonet July 1, 2024 14:09 — with GitHub Actions Inactive
@sfauvel sfauvel force-pushed the sfa/1725/conditional_embedding_cardano_cli_in_docker_image branch from 4704a71 to 4e6e69f Compare July 1, 2024 14:15
@sfauvel sfauvel temporarily deployed to testing-sanchonet July 1, 2024 14:23 — with GitHub Actions Inactive
@sfauvel sfauvel merged commit 4409ebb into main Jul 1, 2024
84 of 85 checks passed
@sfauvel sfauvel deleted the sfa/1725/conditional_embedding_cardano_cli_in_docker_image branch July 1, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants