Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ssh key #1578

Merged
merged 3 commits into from
Mar 20, 2024
Merged

Add ssh key #1578

merged 3 commits into from
Mar 20, 2024

Conversation

sfauvel
Copy link
Collaborator

@sfauvel sfauvel commented Mar 19, 2024 •
edited
Loading

Content

This PR add ssh key to infra

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 19, 2024 •
edited
Loading

Test Results

    3 files  ±0     42 suites  ±0   8m 22s ⏱️ -25s
  923 tests ±0    923 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 012 runs  ±0  1 012 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 3747889. ± Comparison against base commit b65ff69.

♻️ This comment has been updated with latest results.

jpraynaud
jpraynaud approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sfauvel sfauvel temporarily deployed to testing-sanchonet March 20, 2024 13:53 — with GitHub Actions Inactive
sfauvel and others added 2 commits March 20, 2024 15:03
@sfauvel
Add ssh key
18eb4e7
@jpraynaud @sfauvel
chore: actualize the ssh keys
957fdac 
And limit root access to the minimum.
@sfauvel sfauvel temporarily deployed to testing-sanchonet March 20, 2024 14:13 — with GitHub Actions Inactive
@sfauvel sfauvel temporarily deployed to testing-sanchonet March 20, 2024 14:23 — with GitHub Actions Inactive
@sfauvel sfauvel merged commit 57ab7b1 into main Mar 20, 2024
41 checks passed
@sfauvel sfauvel deleted the sfa/add_ssh_key branch March 20, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpraynaud jpraynaud jpraynaud approved these changes

@Alenar Alenar Alenar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfauvel @Alenar @jpraynaud