feat(extension): allow hiding dapps based on feature flag config [LW-11883] #1653
+151
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allure Report
processReports: ❌ test report for 23122e20
|
szymonmaslowski
force-pushed
the
feat/LW-11882-connect-to-dapp-radar
branch
from
a80d784 to
78be196
Compare
przemyslaw-wlodek
force-pushed
the
feat/LW-11883-hide-dapps-using-feature-flags
branch
5 times, most recently
from
69822ea to
9cf2359
Compare
szymonmaslowski
approved these changes
Jan 20, 2025
| @@ -35,6 +35,9 @@ inputs: | |||
| BLOCKFROST_PROJECT_ID_SANCHONET: | |||
| description: 'SanchoNet Project ID for Blockfrost API usage' | |||
| required: true | |||
| DAPP_RADAR_API_KEY: | |||
There was a problem hiding this comment.
Please remove this change. Intentionally we want to set the api key only in the release job which does not use this action templeate.
There was a problem hiding this comment.
Sorry, I think it was a rebase mistake.
Comment on lines
387
to
390
| (payloadsByFeatureTotal, featureFlagName) => ({ | ||
| ...payloadsByFeatureTotal, | ||
| [featureFlagName]: false | ||
| }), |
There was a problem hiding this comment.
Suggested change
| (payloadsByFeatureTotal, featureFlagName) => ({ | |
| ...payloadsByFeatureTotal, | |
| [featureFlagName]: false | |
| }), | |
| (payloadsByFeatureTotal, featureFlagName) => { | |
| payloadsByFeatureTotal[featureFlagName] = false; | |
| return payloadsByFeatureTotal; | |
| }, |
There was a problem hiding this comment.
Yup, I agree. It has the same effect but optimized 👍🏻
- introduce Feature Flag payload validation - allow defining types for custom payloads - improve error handling - add new method PostHogClient.getFeatureFlagPayload()
szymonmaslowski
force-pushed
the
feat/LW-11883-hide-dapps-using-feature-flags
branch
from
9cf2359 to
23122e2
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Proposed solution
Testing
Change the
dapp-explorerfeature flag config and see how/if Dapps are rendered