Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nami): pending tx poc #1608

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

vetalcore
Copy link
Contributor

Checklist

  • JIRA - no ticket yet
  • Proper tests implemented
  • Screenshots added.

Proposed solution

Considering that lace currently operates with activities and since no pending tx info (only skeleton) is currently displayed in the nami/nami mode, we should compile a list of requirements that should be mapped as DoDs in the potential ticket.

  • review existing pr in the nami repo, that brings mempool history support?
  • transaction icon to display (lace shows same icon for all pending tx)
  • define total amount displayed (+assets)
  • defined extra info that could be displayed base on pending tx type
  • handle signed (awaiting cosignatures) transactions
  • anything more?

Testing

Describe here, how the new implementation can be tested.
Provide link or briefly describe User Acceptance Criteria/Tests that need to be met

Screenshots

Screenshot 2024-12-19 at 14 22 46

@vetalcore vetalcore self-assigned this Dec 19, 2024
@vetalcore vetalcore requested a review from a team as a code owner December 19, 2024 12:43
@vetalcore vetalcore marked this pull request as draft December 19, 2024 12:43
Copy link

@pczeglik-iohk
Copy link
Contributor

Allure Report

allure-report-publisher generated test report!

processReports: ✅ test report for 92019507

passed failed skipped flaky total result
Total 33 0 4 0 37

@vetalcore vetalcore requested a review from mchappell December 19, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants