-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove unused onboarding components #1585
Conversation
Allure Report
processReports: ✅ test report for 0723d58f
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How did you determine what are old onboarding components @greatertomi?
Is this PR part of some existing JIRA ticket? Is @ljagiela going to test this? |
These components are not used anywhere. |
I have no idea to be honest. Maybe if e2e tests pass we are good. Lets maybe see what is the expectation for @szymonmaslowski PR |
8d64227
to
23f96ad
Compare
I'd recommend to run full e2e regression for this PR. Onboarding is quite well covered with automation. |
23f96ad
to
0723d58
Compare
Quality Gate passedIssues Measures |
Checklist
Proposed solution
Explain how does this PR solves the problem stated in JIRA ticket.
You can also enumerate different alternatives considered while approaching this task.
Testing
Describe here, how the new implementation can be tested.
Provide link or briefly describe User Acceptance Criteria/Tests that need to be met
Screenshots
Attach screenshots here if implementation involves some UI changes