Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unused onboarding components #1585

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

greatertomi
Copy link
Contributor

Checklist

  • JIRA - <link>
  • Proper tests implemented
  • Screenshots added.

Proposed solution

Explain how does this PR solves the problem stated in JIRA ticket.
You can also enumerate different alternatives considered while approaching this task.

Testing

Describe here, how the new implementation can be tested.
Provide link or briefly describe User Acceptance Criteria/Tests that need to be met

Screenshots

Attach screenshots here if implementation involves some UI changes

@greatertomi greatertomi requested a review from a team as a code owner December 10, 2024 11:59
@pczeglik-iohk
Copy link
Contributor

pczeglik-iohk commented Dec 10, 2024

Allure Report

allure-report-publisher generated test report!

processReports: ✅ test report for 0723d58f

passed failed skipped flaky total result
Total 32 0 4 0 36

Copy link
Contributor

@pczeglik-iohk pczeglik-iohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you determine what are old onboarding components @greatertomi?

@pczeglik-iohk
Copy link
Contributor

Is this PR part of some existing JIRA ticket? Is @ljagiela going to test this?

@greatertomi
Copy link
Contributor Author

How did you determine what are old onboarding components @greatertomi?

These components are not used anywhere.

@greatertomi
Copy link
Contributor Author

Is this PR part of some existing JIRA ticket? Is @ljagiela going to test this?

It is not part of any ticket. @ljagiela can test it. Do I need to create a ticket for this?

@pczeglik-iohk
Copy link
Contributor

Is this PR part of some existing JIRA ticket? Is @ljagiela going to test this?

It is not part of any ticket. @ljagiela can test it. Do I need to create a ticket for this?

I have no idea to be honest. Maybe if e2e tests pass we are good.

Lets maybe see what is the expectation for @szymonmaslowski PR

@greatertomi greatertomi force-pushed the feat/remove-old-onboarding-components branch from 8d64227 to 23f96ad Compare December 10, 2024 16:08
@ljagiela
Copy link
Contributor

I'd recommend to run full e2e regression for this PR. Onboarding is quite well covered with automation.

@greatertomi greatertomi force-pushed the feat/remove-old-onboarding-components branch from 23f96ad to 0723d58 Compare December 10, 2024 16:14
Copy link

sonarcloud bot commented Dec 10, 2024

@greatertomi greatertomi changed the title fix: remove old onboarding components fix: remove old unused onboarding components Dec 10, 2024
@greatertomi greatertomi changed the title fix: remove old unused onboarding components fix: remove unused onboarding components Dec 10, 2024
@greatertomi greatertomi merged commit 995014a into main Dec 11, 2024
47 of 49 checks passed
@greatertomi greatertomi deleted the feat/remove-old-onboarding-components branch December 11, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants