-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [lw-11875] differentiate between locked and spendable rewards #1557
Open
vetalcore
wants to merge
1
commit into
main
Choose a base branch
from
fix/lw-11875-handle-locked-rewards-in-activity-detail
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix: [lw-11875] differentiate between locked and spendable rewards #1557
vetalcore
wants to merge
1
commit into
main
from
fix/lw-11875-handle-locked-rewards-in-activity-detail
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vetalcore
force-pushed
the
fix/lw-11875-handle-locked-rewards-in-activity-detail
branch
from
November 22, 2024 09:54
75f9cb4
to
84f358b
Compare
vetalcore
commented
Nov 22, 2024
apps/browser-extension-wallet/src/stores/slices/wallet-activities-slice.ts
Show resolved
Hide resolved
apps/browser-extension-wallet/src/stores/slices/wallet-activities-slice.ts
Outdated
Show resolved
Hide resolved
Allure Report
processReports: ❌ test report for 86b5ab80
|
vetalcore
force-pushed
the
fix/lw-11875-handle-locked-rewards-in-activity-detail
branch
2 times, most recently
from
November 22, 2024 10:58
0eeda98
to
86be91c
Compare
… activity details
vetalcore
force-pushed
the
fix/lw-11875-handle-locked-rewards-in-activity-detail
branch
from
November 26, 2024 15:25
86be91c
to
86b5ab8
Compare
Quality Gate passedIssues Measures |
apps/browser-extension-wallet/src/stores/slices/wallet-activities-slice.ts
Show resolved
Hide resolved
mirceahasegan
approved these changes
Nov 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
differentiate between locked and spendable rewards in activity details
Checklist
Proposed solution
Display "Locked" status for reward account details if current network is PV10 and If rewards for that stake address are associated with a vote delegated account.
Testing
Describe here, how the new implementation can be tested.
Provide link or briefly describe User Acceptance Criteria/Tests that need to be met
Screenshots