Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [lw-11875] differentiate between locked and spendable rewards #1557

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vetalcore
Copy link
Contributor

@vetalcore vetalcore commented Nov 22, 2024

differentiate between locked and spendable rewards in activity details

Checklist

  • JIRA - LW-11875
  • Proper tests implemented
  • Screenshots added.

Proposed solution

Display "Locked" status for reward account details if current network is PV10 and If rewards for that stake address are associated with a vote delegated account.

Testing

Describe here, how the new implementation can be tested.
Provide link or briefly describe User Acceptance Criteria/Tests that need to be met

Screenshots

Screenshot 2024-11-22 at 11 39 31

@vetalcore vetalcore self-assigned this Nov 22, 2024
@vetalcore vetalcore requested a review from a team as a code owner November 22, 2024 09:54
@vetalcore vetalcore force-pushed the fix/lw-11875-handle-locked-rewards-in-activity-detail branch from 75f9cb4 to 84f358b Compare November 22, 2024 09:54
@pczeglik-iohk
Copy link
Contributor

pczeglik-iohk commented Nov 22, 2024

Allure Report

allure-report-publisher generated test report!

processReports: ❌ test report for 86b5ab80

passed failed skipped flaky total result
Total 30 2 4 0 36

@vetalcore vetalcore force-pushed the fix/lw-11875-handle-locked-rewards-in-activity-detail branch 2 times, most recently from 0eeda98 to 86be91c Compare November 22, 2024 10:58
@vetalcore vetalcore force-pushed the fix/lw-11875-handle-locked-rewards-in-activity-detail branch from 86be91c to 86b5ab8 Compare November 26, 2024 15:25
Copy link

sonarcloud bot commented Nov 26, 2024

Copy link
Contributor

@mirceahasegan mirceahasegan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants