-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [lw-11830]: handle not delegated stake keys scenarios in send flow #1543
Open
vetalcore
wants to merge
3
commits into
main
Choose a base branch
from
feat/lw-11830-handle-not-delegated-stake-keys-send-flow
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix: [lw-11830]: handle not delegated stake keys scenarios in send flow #1543
vetalcore
wants to merge
3
commits into
main
from
feat/lw-11830-handle-not-delegated-stake-keys-send-flow
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allure Report
processReports: ❌ test report for fce46a35
|
vetalcore
force-pushed
the
feat/lw-11830-handle-not-delegated-stake-keys-send-flow
branch
from
November 26, 2024 15:22
18975ed
to
dba4245
Compare
...let/src/views/browser-view/features/send-transaction/components/Form/CoinInput/CoinInput.tsx
Outdated
Show resolved
Hide resolved
...r-extension-wallet/src/views/browser-view/features/send-transaction/components/Form/Form.tsx
Outdated
Show resolved
Hide resolved
apps/browser-extension-wallet/src/views/browser-view/features/staking/hooks.ts
Show resolved
Hide resolved
vetalcore
force-pushed
the
feat/lw-11830-handle-not-delegated-stake-keys-send-flow
branch
from
November 27, 2024 13:22
759e9d0
to
43bcc48
Compare
vetalcore
force-pushed
the
feat/lw-11830-handle-not-delegated-stake-keys-send-flow
branch
from
November 28, 2024 13:14
43bcc48
to
fce46a3
Compare
Quality Gate passedIssues Measures |
mirceahasegan
approved these changes
Nov 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic work @vetalcore !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Proposed solution
Explain how does this PR solves the problem stated in JIRA ticket.
You can also enumerate different alternatives considered while approaching this task.
Testing
Describe here, how the new implementation can be tested.
Provide link or briefly describe User Acceptance Criteria/Tests that need to be met
Screenshots