Skip to content

Expose openHandles #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jasagredo merged 1 commit into from
Oct 21, 2024
Merged

Expose openHandles #81

jasagredo merged 1 commit into from
Oct 21, 2024

Conversation

@jasagredo
Copy link
Contributor

@jasagredo jasagredo commented Oct 17, 2024

Exposing this function is useful to check not only that there are open handles but also what are those handles filepaths.

@jasagredo jasagredo requested a review from a team as a code owner October 17, 2024 14:01
jorisdral
jorisdral suggested changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@jorisdral jorisdral left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me, but openHandles returns OpenHandleState, which is an opaque type. Are you only printing the result of openHandles?

@jasagredo
Copy link
Contributor Author

jasagredo commented Oct 17, 2024

Indeed I'm just doing:

counterexample (show (Mock.openHandles fs)) $ ...

@jasagredo jasagredo requested a review from jorisdral October 21, 2024 05:50
@jasagredo jasagredo enabled auto-merge October 21, 2024 05:50
@jasagredo jasagredo added this pull request to the merge queue Oct 21, 2024
Merged via the queue into main with commit 2d85d65 Oct 21, 2024
22 checks passed
@jasagredo jasagredo deleted the js/openhandles branch October 21, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jorisdral jorisdral jorisdral approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jasagredo @jorisdral