Skip to content

fix(rust/signed-doc): Correct CBOR content type and data validation #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

apskhem
Copy link
Collaborator

@apskhem apskhem commented May 27, 2025

Description

  • Fixed CBOR validation using .skip()
  • Moved the validation method and the test from metadata/content_type.rs to validator/rules/content_type.rs

Related Issue(s)

Closes #348

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@apskhem apskhem self-assigned this May 27, 2025
@apskhem apskhem added the bug Something isn't working label May 27, 2025
@apskhem apskhem linked an issue May 27, 2025 that may be closed by this pull request
2 tasks
@apskhem apskhem requested review from Mr-Leshiy and no30bit May 27, 2025 12:15
Copy link
Contributor

github-actions bot commented May 27, 2025

Test Report | ${\color{lightgreen}Pass: 338/338}$ | ${\color{red}Fail: 0/338}$ |

@apskhem apskhem marked this pull request as draft May 28, 2025 06:14
@apskhem apskhem marked this pull request as ready for review May 28, 2025 10:46
@apskhem apskhem requested review from Mr-Leshiy and stevenj May 28, 2025 10:48
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mr-Leshiy Mr-Leshiy changed the base branch from main to feat/new-cat-signed-doc May 29, 2025 03:51
@apskhem apskhem added the review me PR is ready for review label May 29, 2025
@Mr-Leshiy Mr-Leshiy merged commit b3be754 into feat/new-cat-signed-doc May 30, 2025
21 of 24 checks passed
@Mr-Leshiy Mr-Leshiy deleted the fix/signed-docs-content-type-validation branch May 30, 2025 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working review me PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Catalyst Signed Document ContentType validation
4 participants