Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds nightly job #113

Merged
merged 6 commits into from
Jan 17, 2025
Merged

feat: adds nightly job #113

merged 6 commits into from
Jan 17, 2025

Conversation

kukkok3
Copy link
Contributor

@kukkok3 kukkok3 commented Jan 16, 2025

This PR adds a nightly job to forge

@kukkok3 kukkok3 self-assigned this Jan 16, 2025
@kukkok3 kukkok3 marked this pull request as ready for review January 16, 2025 11:02
@kukkok3 kukkok3 requested a review from jmgilman January 16, 2025 11:02
@jmgilman
Copy link
Collaborator

Do we want the nightly job always running in PR's? Nightly tasks are usually much longer in duration and if we ran them on every update It would make existing PR runs even longer than they are now.

@kukkok3
Copy link
Contributor Author

kukkok3 commented Jan 17, 2025

Do we want the nightly job always running in PR's? Nightly tasks are usually much longer in duration and if we ran them on every update It would make existing PR runs even longer than they are now.

The nightly job only runs when inputs.nightly flag is set to true if that is what you mean?

if: (fromJson(needs.discover.outputs.earthfiles)['^nightly(-.*)?$'] != null) && !failure() && !cancelled() && inputs.nightly == true

@jmgilman
Copy link
Collaborator

Ah, I missed that last bit in the conditional. So the goal is to create a separate nightly workflow in the repos and set this input to true?

@kukkok3
Copy link
Contributor Author

kukkok3 commented Jan 17, 2025

Ah, I missed that last bit in the conditional. So the goal is to create a separate nightly workflow in the repos and set this input to true?

Yes exactly https://github.com/input-output-hk/catalyst-voices/blob/70d58a767cf5ccaac84a23a220e4ae266a713a4d/.github/workflows/nightly-ci.yml#L26

jmgilman
jmgilman previously approved these changes Jan 17, 2025
Copy link
Collaborator

@jmgilman jmgilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmgilman jmgilman merged commit a0516ff into master Jan 17, 2025
21 checks passed
@jmgilman jmgilman deleted the feat/nightly-job branch January 17, 2025 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants