Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflows to use actions/upload-artifact@v4 #169

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Conversation

tyrann0us
Copy link
Member

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

  • Updated both .github/workflows/build-assets-compilation.yml and .github/workflows/ddev-playwright.yml to use actions/upload-artifact@v4
  • Added overwrite: true to allow overwriting artifacts with the same name
  • Set include-hidden-files: true to ensure hidden files are included in artifact uploads

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No breaking changes are introduced. Existing workflows and processes should continue to function as before.

However, please test the PR branch in your calling workflows to double-check!

Other information:
For the Playwright workflow, an alternative would be to append ${{ github.run_id }} to the artifact name to ensure uniqueness and prevent collisions. However, this could cause regressions in downstream processes dependent on a consistent artifact name. Therefore, I opted to use overwrite: true to maintain the existing artifact naming convention while accommodating the immutability changes in actions/upload-artifact@v4.

Also, as a Boy Scout rule, I aligned the CODEOWNERS and dependabot.yml files with https://github.com/inpsyde/actions.

@Chrico Chrico removed request for shvlv and Biont November 6, 2024 09:47
@tyrann0us tyrann0us merged commit d3cda33 into main Nov 6, 2024
4 checks passed
@tyrann0us tyrann0us deleted the artifacts-v4 branch November 6, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants