Update workflows to use actions/upload-artifact@v4 #169
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
.github/workflows/build-assets-compilation.yml
and.github/workflows/ddev-playwright.yml
to useactions/upload-artifact@v4
overwrite: true
to allow overwriting artifacts with the same nameinclude-hidden-files: true
to ensure hidden files are included in artifact uploadsDoes this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No breaking changes are introduced. Existing workflows and processes should continue to function as before.
However, please test the PR branch in your calling workflows to double-check!
Other information:
For the Playwright workflow, an alternative would be to append
${{ github.run_id }}
to the artifact name to ensure uniqueness and prevent collisions. However, this could cause regressions in downstream processes dependent on a consistent artifact name. Therefore, I opted to useoverwrite: true
to maintain the existing artifact naming convention while accommodating the immutability changes inactions/upload-artifact@v4
.Also, as a Boy Scout rule, I aligned the
CODEOWNERS
anddependabot.yml
files with https://github.com/inpsyde/actions.