Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build-and-push-assets.md - fix basic usage #168

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

Chrico
Copy link
Member

@Chrico Chrico commented Oct 29, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

The basic usage contains push.branches with wildcard *. This will cause an endless loop because for main a main-built is created which creates a main-built-built. By updating the basic example we still listen to all branches via * but now exclude all *-built branches for re-triggering the workflow and creating a loop

Signed-off-by: Christian Leucht <[email protected]>
Signed-off-by: Christian Leucht <[email protected]>
Copy link
Member

@tyrann0us tyrann0us left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Chrico Chrico merged commit 43e3e34 into main Oct 29, 2024
3 checks passed
@Chrico Chrico deleted the fix/docs-build-and-push-assets.md branch October 29, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants