Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional tools for plugin archives: php-scoper, rector #134

Merged
merged 50 commits into from
Sep 4, 2024

Conversation

Biont
Copy link
Member

@Biont Biont commented Jun 20, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature

What is the current behavior? (You can also link to an open issue here)
The existing multi-step plugin archive workflow can currently identify and execute the following tools

  • asset compilation via inpsyde/composer-asset-compiler
  • translation download via inpsyde/wp-translation-downloader

What is the new behavior (if this is a feature change)?
In addition, the following "post-processing" tools are introduced

  • namespace prefixing via humbug/php-scoper
  • transpilation of php8 code via rectorphp/rector

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No

Other information:

Biont and others added 30 commits February 28, 2024 12:57
# Conflicts:
#	.github/workflows/build-plugin-archive.yml
Co-authored-by: Philipp Bammes <[email protected]>
Signed-off-by: Moritz Meißelbach <[email protected]>
Co-authored-by: Philipp Bammes <[email protected]>
Signed-off-by: Moritz Meißelbach <[email protected]>
Co-authored-by: Philipp Bammes <[email protected]>
Signed-off-by: Moritz Meißelbach <[email protected]>
…d-archives

# Conflicts:
#	.github/workflows/build-plugin-archive.yml
Signed-off-by: Moritz Meißelbach <[email protected]>
@Biont Biont changed the title Prefixed plugin archives via php-scoper Additional tools for plugin archives: php-scoper, rector Jul 25, 2024
.github/workflows/build-plugin-archive.yml Show resolved Hide resolved
.github/workflows/build-plugin-archive.yml Outdated Show resolved Hide resolved
.github/workflows/build-plugin-archive.yml Outdated Show resolved Hide resolved
.github/workflows/build-plugin-archive.yml Outdated Show resolved Hide resolved
.github/workflows/build-plugin-archive.yml Outdated Show resolved Hide resolved
.github/workflows/build-plugin-archive.yml Show resolved Hide resolved
.github/workflows/build-plugin-archive.yml Outdated Show resolved Hide resolved
@tyrann0us tyrann0us mentioned this pull request Sep 3, 2024
1 task
Biont and others added 5 commits September 3, 2024 14:10
Co-authored-by: Philipp Bammes <[email protected]>
Signed-off-by: Moritz Meißelbach <[email protected]>
Co-authored-by: Philipp Bammes <[email protected]>
Signed-off-by: Moritz Meißelbach <[email protected]>
Co-authored-by: Philipp Bammes <[email protected]>
Signed-off-by: Moritz Meißelbach <[email protected]>
breaking change in actions/upload-artifact

Signed-off-by: Alex Pantechovskis <[email protected]>
@AlexP11223
Copy link
Contributor

Added include-hidden-files: true in uploads, to fix this breaking change: actions/upload-artifact#602

@tyrann0us tyrann0us marked this pull request as ready for review September 4, 2024 11:24
Copy link
Member

@tyrann0us tyrann0us left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for incorporating all the changes. Left a minor round of suggestions to get the new lines straight, but this doesn't stop me from approving.

.github/workflows/build-plugin-archive.yml Outdated Show resolved Hide resolved
.github/workflows/build-plugin-archive.yml Show resolved Hide resolved
.github/workflows/build-plugin-archive.yml Show resolved Hide resolved
Biont and others added 3 commits September 4, 2024 14:54
Co-authored-by: Philipp Bammes <[email protected]>
Signed-off-by: Moritz Meißelbach <[email protected]>
Co-authored-by: Philipp Bammes <[email protected]>
Signed-off-by: Moritz Meißelbach <[email protected]>
Co-authored-by: Philipp Bammes <[email protected]>
Signed-off-by: Moritz Meißelbach <[email protected]>
@tyrann0us tyrann0us merged commit db67323 into main Sep 4, 2024
1 check passed
@tyrann0us tyrann0us deleted the feature/prefixed-archives branch September 4, 2024 13:06
@Biont Biont restored the feature/prefixed-archives branch September 4, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants