Merged
Conversation
gmazzap
reviewed
Mar 7, 2024
Contributor
gmazzap
left a comment
There was a problem hiding this comment.
Firts of all, thank you for this.
I'm not super-happy about the folders structure, I think it is not inline with current code.
The test-pakage is a fixture, after all. So it can go in the tests/fixture folder.
And the E2eTest.php file is a test case, so it can go in the tests/cases folder.
So we would have:
|_ tests/
|_ cases/
|_ e2e/
|_ E2eTest.php
|_ unit/
|_ Helpers/
FixturesTest.php
|_ fixtures/
|_ unit/
|_ argument-type-declaration.php
|_ disable-call-user-func.php
|_ ...
|_ e2e/
|_ test-package/
|_ src/
|_ autoload.php
|_ bootstrap.php
This requires a bit of adjustment for the paths uses right now, but I think it looks to me a better organization.
Alternatively:
|_ tests/
|_ unit/
cases/
|_ Helpers/
FixturesTest.php
fixtures/
|_ argument-type-declaration.php
|_ disable-call-user-func.php
|_ ...
|_ e2e/
|_ cases/
|_ E2eTest.php
|_ fixtures/
|_ test-package/
|_ src/
|_ autoload.php
|_ bootstrap.php
What do you think?
Contributor
Author
|
I like the second approach more. Does it look good to you? |
gmazzap
approved these changes
Mar 7, 2024
tfrommen
reviewed
Mar 7, 2024
gmazzap
approved these changes
Mar 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Tests.
What is the current behavior? (You can also link to an open issue here)
No E2E tests.
What is the new behavior (if this is a feature change)?
E2E tests to prevent possible regressions for
InpsydeandInpsydeTemplatesCS usage.See - #85.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No.
Other information: