-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature/59] Add rules against arrow function feature #62
Conversation
Apparently `getDeclarationName` will never support T_FN.
Question: // This should be disallowed.
add_action('foo', fn ($foo) => 'x');
// Because we want:
add_action('foo', static fn ($foo) => 'x'); |
The feature branch we were using has been merged.
I added support tot is as well @tangrufus |
Looks like this was the final PR into master which has since been deleted? I can open an issue if needed. |
@thefrosty the branch And then, the So all the changes in this PR are already both in For forward compatibility, if you plan to test the changes, please require the package via But please be aware that v2 is a work in progress for now, bugs are expected, and we would appreciate help in testing. |
That's fine, I know previously there was some issues with v1 and maybe composer api v2, so we discussed using |
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Feature
What is the current behavior?
There is no rules against arrow function feature.
What is the new behavior?
Rules are being added
Does this PR introduce a breaking change?
No