Skip to content

Conversation

@obiwac
Copy link
Member

@obiwac obiwac commented Dec 25, 2024

Resolves #33
Also see inobulles/aquarium#48

To do:

  • AquariumBuilder class.
  • Aquarium class.
  • Preemptive check for if aquariums are installed, so we don't run any of the build steps (can just do a list command and see if that fails ig).
  • Put the aquarium Bob stuff in bob.aquarium I guess.
  • Look through TODO's in added code cuh I'm pretty sure there's a bunch of important stuff I forgot.
  • Figure out where to put root.img and esp.img temporary artifacts (should aquariums just be responsible for these and put them in /usr/local/aquarium somewhere?).
  • Find an elegant way to output artifacts, like bob out bootable.img or something, and an out value which just takes in a cookie you wanna use (probably in it's own PR before this one). Alternatively, I could have an "artifacts" system with an artifacts map.
  • Update the VERSION #define and maybe add a CI check for this.

It's infeasible to do tests on this in Bob. But since I want all aquariums to move to being built by Bob, tests for aquariums will naturally test for the Bob implementation too (I wonder if there's a standard way to trigger CI on other projects dependant projects? because then this could be automated).

@obiwac obiwac force-pushed the feature/aquariums branch from bee7b87 to 33bbee7 Compare December 1, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature, yo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Be able to create aquariums

2 participants