-
Notifications
You must be signed in to change notification settings - Fork 0
Aquariums #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
obiwac
wants to merge
22
commits into
main
Choose a base branch
from
feature/aquariums
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Aquariums #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cc36d13 to
a392129
Compare
518986a to
87aab2f
Compare
00302e3 to
2125f38
Compare
Open
2125f38 to
f3983c7
Compare
f3983c7 to
6e74203
Compare
6e74203 to
bee7b87
Compare
…ormation the build step needs)
bee7b87 to
33bbee7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #33
Also see inobulles/aquarium#48
To do:
AquariumBuilderclass.Aquariumclass.bob.aquariumI guess.root.imgandesp.imgtemporary artifacts (should aquariums just be responsible for these and put them in/usr/local/aquariumsomewhere?).bob out bootable.imgor something, and anoutvalue which just takes in a cookie you wanna use (probably in it's own PR before this one). Alternatively, I could have an "artifacts" system with an artifacts map.VERSION#defineand maybe add a CI check for this.It's infeasible to do tests on this in Bob. But since I want all aquariums to move to being built by Bob, tests for aquariums will naturally test for the Bob implementation too (I wonder if there's a standard way to trigger CI on other projects dependant projects? because then this could be automated).