Use the platform of the source Mach-O file unless ignore_platform #11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On base branch:
Note that
platform
isnull
.With PR:
I think that the tbd platform should be selected from the source Mach-O in all cases except if
ignore_platform
is it.ignore_targets
impliesignore_platform
.In the
handle_targets_platform_and_uuid
function that this PR changes,ignore_targets
is checked first, so I believe both of these cases are handled.