Merge pull request #25 from innogames/unity2019-compatibility

Unity2019 compatibility
innogames · Apr 26, 2024 · 53c38aa · 53c38aa
2 parents 2141e69 + d6a03f2
commit 53c38aa
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 6 deletions.
diff --git a/NodeDependencyLookup/Editor/NodeHandler/AssetNodeHandler.cs b/NodeDependencyLookup/Editor/NodeHandler/AssetNodeHandler.cs
@@ -95,7 +95,7 @@ public bool IsNodePackedToApp(Node node, bool alwaysExcluded = false)
 		public bool IsNodeEditorOnly(string id, string type)
 		{
 			var path = AssetDatabase.GUIDToAssetPath(NodeDependencyLookupUtility.GetGuidFromAssetId(id));
-			return path.Contains("/Editor/", StringComparison.Ordinal);
+			return path.Contains("/Editor/");
 		}
 
 		public void InitNodeCreation()
@@ -283,7 +283,7 @@ private bool IsSceneAndPacked(string path)
 
 		private bool IsInResources(string path)
 		{
-			return path.Contains("/Resources/", StringComparison.Ordinal);
+			return path.Contains("/Resources/");
 		}
 	}
 }
diff --git a/NodeDependencyLookup/Editor/NodeHandler/FileNodeHandler.cs b/NodeDependencyLookup/Editor/NodeHandler/FileNodeHandler.cs
@@ -235,7 +235,7 @@ public bool IsNodePackedToApp(Node node, bool alwaysExcluded)
 		public bool IsNodeEditorOnly(string id, string type)
 		{
 			var path = AssetDatabase.GUIDToAssetPath(id);
-			return path.Contains("/Editor/", StringComparison.Ordinal);
+			return path.Contains("/Editor/");
 		}
 
 		public Node CreateNode(string id, string type, bool update, out bool wasCached)
@@ -309,6 +309,6 @@ private bool IsSceneAndPacked(string path)
 			return false;
 		}
 
-		private bool IsInResources(string path) => path.Contains("/Resources/", StringComparison.Ordinal);
+		private bool IsInResources(string path) => path.Contains("/Resources/");
 	}
 }
diff --git a/NodeDependencyLookup/Editor/Utility/NodeDependencyLookupUtility.cs b/NodeDependencyLookup/Editor/Utility/NodeDependencyLookupUtility.cs
@@ -296,11 +296,13 @@ private static string GetAssetDatabaseVersion1LibraryDataPath(string guid)
 		public static bool IsNodePackedToApp(Node node, NodeDependencyLookupContext stateContext,
 			Dictionary<string, bool> checkedPackedStates)
 		{
-			if (!checkedPackedStates.TryAdd(node.Key, false))
+			if (checkedPackedStates.ContainsKey(node.Key))
 			{
 				return checkedPackedStates[node.Key];
 			}
 
+			checkedPackedStates.Add(node.Key, false);
+
 			var nodeHandler = stateContext.NodeHandlerLookup[node.Type];
 
 			if (nodeHandler.GetHandledNodeType().Contains(node.Type))

diff --git a/changelog.md b/changelog.md
@@ -1,3 +1,6 @@
+**3.0.2**
+- Regression from 3.0.1 - Revert changes that are not 2019.4 compatible
+
 **3.0.1**
 - Improve string comparison and allocations for faster processing
 - Cleanup naming "pathes" -> "paths"

diff --git a/package.json b/package.json
@@ -2,7 +2,7 @@
   "name": "com.innogames.asset-relations-viewer",
   "displayName": "Asset Relations Viewer",
   "description": "Editor UI for displaying dependencies between assets in a tree based view",
-  "version": "3.0.1",
+  "version": "3.0.2",
   "unity": "2019.4",
   "license": "MIT",
   "repository": {