Skip to content

remove (nearly) useless const for fn #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 5, 2025

Conversation

haraldmaida
Copy link
Member

some functions have been declared as const fn although it necessarely could not be used in a const context, or would not make sense.

Re-visited the public API and made const fn non const if there is no good reason for the function to be const.

@haraldmaida haraldmaida added the enhancement New feature or request label Apr 5, 2025
@haraldmaida haraldmaida self-assigned this Apr 5, 2025
Copy link

codecov bot commented Apr 5, 2025

Codecov Report

Attention: Patch coverage is 14.28571% with 12 lines in your changes missing coverage. Please review.

Project coverage is 89.81%. Comparing base (7e61072) to head (f940761).

Files with missing lines Patch % Lines
src/spec/mod.rs 14.28% 12 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main       #6   +/-   ##
=======================================
  Coverage   89.81%   89.81%           
=======================================
  Files          18       18           
  Lines        1385     1385           
  Branches     1385     1385           
=======================================
  Hits         1244     1244           
  Misses        137      137           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@haraldmaida haraldmaida merged commit 7d19013 into main Apr 5, 2025
17 of 18 checks passed
@haraldmaida haraldmaida deleted the revisit-const-fn-in-public-api branch April 5, 2025 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant