Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support signature validation in Dev mode #147

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Support signature validation in Dev mode #147

wants to merge 2 commits into from

Conversation

amh4r
Copy link
Collaborator

@amh4r amh4r commented Aug 25, 2024

Support request signature validation when in Dev mode. Before these changes, the SDK ignored request signatures when in Dev mode.

New tests demonstrate the expected behavior:

  • If request signature header exists, then perform validation regardless of SDK mode.
  • If request signature doesn't exist and the SDK is in Dev mode, then skip validation.

@amh4r amh4r requested a review from jpwilliams August 25, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpwilliams jpwilliams Awaiting requested review from jpwilliams

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@amh4r