WIP: add defaults and move functions to provision package #23
+239
−237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Johnson <[email protected]>
adamjohnson01
force-pushed
the
provisioner-defaults
branch
from
6edf1d4
to
b46b056
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As suggested in #17 I have created this pull request to demonstrate what I am proposing. This ended up being a little more than I was originally suggesting as I have also moved a couple of functions into provision as well. After looking at the code in the operator project I think we can remove some of the duplication by doing this or some of it.
How Has This Been Tested?
I have tested it, but this if for demonstration purposes for the moment and will require a little more work
How are existing users impacted? What migration steps/scripts do we need?
This would only require changes if downstream users wanted to use the defaults instead of setting them.
Checklist:
I have:
git commit -s