Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add output to create command for deletion of exit node #20

Merged
merged 1 commit into from
Jan 5, 2020

Conversation

adamjohnson01
Copy link
Contributor

@adamjohnson01 adamjohnson01 commented Jan 3, 2020

Description

The create command will not output the delete command for the exit node
that was just created. Related to #2

How Has This Been Tested?

I have tested with all providers except packet.

Using provider: digitalocean
Requesting host: angry-archimedes1 in , from digitalocean
2020/01/03 14:14:44 Provisioning host with DigitalOcean
Host: 174061244, status:
[1/500] Host: 174061244, status: new
[2/500] Host: 174061244, status: new
[3/500] Host: 174061244, status: new
[4/500] Host: 174061244, status: new
[5/500] Host: 174061244, status: new
[6/500] Host: 174061244, status: new
[7/500] Host: 174061244, status: new
[8/500] Host: 174061244, status: new
[9/500] Host: 174061244, status: new
[10/500] Host: 174061244, status: new
[11/500] Host: 174061244, status: active
Inlets OSS exit-node summary:
  IP: 157.245.41.205
  Auth-token: RgsuIGVPhiPuO6e67MvYOU2o4abwSzVc4zUCCO4sx4XCLxNwrbpj6oqSPAFMI6Cr

Command:
  export UPSTREAM=http://127.0.0.1:8000
  inlets client --remote "ws://157.245.41.205:8080" \
	--token "RgsuIGVPhiPuO6e67MvYOU2o4abwSzVc4zUCCO4sx4XCLxNwrbpj6oqSPAFMI6Cr" \
	--upstream $UPSTREAM

To Delete:
  inletsctl delete --provider digitalocean --id "174061244"

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • read the CONTRIBUTION guide
  • signed-off my commits with git commit -s
  • added unit tests

The create command will not output the delete command for the exit node
that was just created.

Signed-off-by: Adam Johnson <[email protected]>
@derek derek bot added the new-contributor label Jan 3, 2020
Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexellis alexellis merged commit 7ff3ed3 into inlets:master Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants