Repository navigation
Discover remote tools and preserve startup and reply identity - #82
Merged
Merged
Conversation
alex-w-99
marked this pull request as ready for review
November 15, 2026 20:42
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
Fixed the call-cleanup race in d261c09. Failed or still-pending hangups remain eligible for retry, and each test verifies cleanup before the next test proceeds. Preexisting calls are preserved. The full local unit suite and focused cleanup regressions passed; live CI remains pending. |
This comment has been minimized.
This comment has been minimized.
dimavrem22
approved these changes
Nov 18, 2026
dimavrem22
left a comment
Contributor
There was a problem hiding this comment.
codex: Verified that an uncertain send no longer becomes a completed delivery and does not trigger a duplicate reply. No code-review blockers remain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Executive Summary
Discover current Inkbox tools in Codex and preserve reliable startup and reply identity.
Description
Plugin version 0.2.41 also makes doctor distinguish managed runtime health from terminal configuration. Managed diagnostics consume a recent, private, identity-matched report; missing or stale evidence cannot report readiness. Terminal sessions do not require the runtime signing key or ordinary webhook subscriptions. Runtime-context signing-key checks and standalone diagnostics remain intact.
Source and CI installs pin SDK 0.7.39 at
84386f5ea022a9594fb901894f927ee444c2cf91. This accepts valid emptyinputRequestscontinuation maps while still rejecting real or malformed interaction requests. Regression fixtures exercise the empty-map response with the actual SDK.Version 0.2.39 fixes contact and explicit-reply MCP calls rejected for extra arguments. Contact aliases send only contact fields; terminal email/SMS replies retain existing receipt fingerprints while keeping execution identity in SDK call options and durable continuations. New actual-SDK tests reject extra input properties and verify retries reuse the prepared operation.
Native stdio metadata supplies stable call identity. Browser Ask sessions apply native MCP approval overrides without changing saved connections, and idle catalog refresh resumes the same conversation. Managed chat/inbox modules reuse the SDK implementation through compatible imports. Remote discovery validates bounded schemas and annotations, and remote calls retain their continuation and native identity across retries. Existing contact names delegate to canonical remote tools; local media, channel delivery and host-specific capabilities remain available as documented in REMOTE_TOOLS.md.
The terminal text helper supports email and SMS with an admitted recipient. Accepted or submitted-but-unconfirmed replies withhold automatic final text for the same source. Ordinary progress sends do not suppress a final reply.
Version 0.2.38 retries live-test hangup requests while calls remain nonterminal and verifies cleanup after each test. Calls present before the test are preserved.
Reason
Tool availability should follow the current catalog, while reconnects and uncertain deliveries must preserve the original operation instead of issuing another send.
Decisions
Testing
Latest full offline suite on
5e913a8: 2,983 passed, 27 skipped; setup-floor regressions include rejecting SDK 0.7.38.Managed diagnostics update: 2,864 unit tests passed; doctor regressions included. Tests cover missing/stale/mismatched reports, unhealthy runtime state, terminal key absence, runtime key requirements, and unchanged standalone behavior.
Latest SDK-pin follow-up: 25 targeted tests passed. This records the earlier focused run; final source checks are reported separately.
Earlier argument-contract fix: 2,859 passed, 27 skipped in the full offline suite. Closed-schema regressions cover contact creation, update, deletion, and terminal replies. Live acceptance on this new head remains pending.
Earlier local unit suite: 2,853 passed, 27 skipped. Three focused cleanup regressions also passed, including an additional timeout regression added after the full run. Changed-file lint passed.
Live model-backed native tests with Codex 0.163.0: remote identity reads, note creation/read/deletion, and denied writes passed. Only test-created objects were removed.
Live remote self-email send and read passed; delivery and receipt were independently verified.
Shared SDK live fault tests recovered a lost successful write response without duplication, kept separate identical calls distinct, and rejected invalid schemas, changed arguments, and cancellation/revocation before submission.
Latest live channel CI must pass independently; local regressions do not establish live acceptance.
Related PRs
0.7.39: Add hosted controls and durable remote tool transports inkbox#243