-
Notifications
You must be signed in to change notification settings - Fork 1
feat: add chain names & tx cache URL #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1fa05e9
to
83db9d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
request for style feedback
yeah, the way to achieve that is to fold the constants into a binary and have that binary's configs/constants object handle it. push relationships between types up to higher abstractions |
6b6954e
to
4cd303d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a few doc nits
SignetEnvironmentConstants
andSignetConstants
(system + environment)TxCache::pecorino()
andTxCache::pecorino_with_client(client: Client)