Skip to content

feat: add chain names & tx cache URL #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
May 19, 2025
Merged

feat: add chain names & tx cache URL #48

merged 15 commits into from
May 19, 2025

Conversation

anna-carroll
Copy link
Contributor

@anna-carroll anna-carroll commented May 9, 2025

  • add SignetEnvironmentConstants and SignetConstants (system + environment)
    • contains names for Host and Rollup networks & the Transaction Cache URL
  • adds TxCache::pecorino() and TxCache::pecorino_with_client(client: Client)
  • updates Filler and Order example code to use new constants

@anna-carroll anna-carroll self-assigned this May 9, 2025
@anna-carroll anna-carroll force-pushed the anna/add-constants branch 2 times, most recently from 1fa05e9 to 83db9d8 Compare May 12, 2025 14:06
Copy link
Contributor Author

@anna-carroll anna-carroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

request for style feedback

@anna-carroll anna-carroll marked this pull request as ready for review May 12, 2025 14:25
@anna-carroll anna-carroll requested a review from a team as a code owner May 12, 2025 14:25
@prestwich
Copy link
Member

I'd rather there be something like SignetEnvironmentConstants::tx_cache()

yeah, the way to achieve that is to fold the constants into a binary and have that binary's configs/constants object handle it. push relationships between types up to higher abstractions

Copy link
Member

@prestwich prestwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few doc nits

@anna-carroll anna-carroll enabled auto-merge (squash) May 19, 2025 13:47
@anna-carroll anna-carroll merged commit 75183cc into main May 19, 2025
6 checks passed
@anna-carroll anna-carroll deleted the anna/add-constants branch May 19, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants