feat(portal): try to detect epsg code from vector added by url #1147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecarn
requested changes
Apr 5, 2024
| concatMap((epsgCode) => { | ||
| return this.importService.import( | ||
| file, | ||
| epsgCode === 'epsgNotDefined' ? undefined : epsgCode |
There was a problem hiding this comment.
J'ai l'impression que cet observable pourrait bloquer lorsqu'un fichier n'a pas de projection.
Au niveau du skipWhile((code) => !code), cela pourrait faire en sorte qu'on accède jamais à la suite des étapes, qu'est-ce que t'en pense?
There was a problem hiding this comment.
Je ne pense pas car dans l'util, il retourne toujours quelque chose.
alecarn
approved these changes
Apr 5, 2024
refactor(geo): refactor based on review
alecarn
force-pushed
the
fix-importing-layer
branch
from
eb28d76
to
d2f88f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1146
tester avec la branche suivante
infra-geo-ouverte/igo2-lib#1637