Skip to content

Commit

Permalink
Patch ibc-proto-rs in check-guide
Browse files Browse the repository at this point in the history
  • Loading branch information
@ljoss17
ljoss17 committed Aug 23, 2024
1 parent 5fad8a7 commit 4ab202e
Show file tree
Hide file tree
Showing 3 changed files with 307 additions and 132 deletions.
2 changes: 1 addition & 1 deletion crates/relayer-types/src/core/ics23_commitment/merkle.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ impl MerkleProof {
match &proof.proof {
Some(Proof::Exist(existence_proof)) => {
subroot =
calculate_existence_root::<ics23::HostFunctionsManager>(existence_proof)
calculate_existence_root::<ics23::HostFunctionsManager>(&existence_proof)

Check failure on line 94 in crates/relayer-types/src/core/ics23_commitment/merkle.rs

View workflow job for this annotation

GitHub Actions / clippy-no-default-features

this expression creates a reference which is immediately dereferenced by the compiler 

error: this expression creates a reference which is immediately dereferenced by the compiler
  --> crates/relayer-types/src/core/ics23_commitment/merkle.rs:94:81
   |
94 |                         calculate_existence_root::<ics23::HostFunctionsManager>(&existence_proof)
   |                                                                                 ^^^^^^^^^^^^^^^^ help: change this to: `existence_proof`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
   = note: `-D clippy::needless-borrow` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::needless_borrow)]`

Check failure on line 94 in crates/relayer-types/src/core/ics23_commitment/merkle.rs

View workflow job for this annotation

GitHub Actions / clippy-no-default-features

this expression creates a reference which is immediately dereferenced by the compiler 

error: this expression creates a reference which is immediately dereferenced by the compiler
  --> crates/relayer-types/src/core/ics23_commitment/merkle.rs:94:81
   |
94 |                         calculate_existence_root::<ics23::HostFunctionsManager>(&existence_proof)
   |                                                                                 ^^^^^^^^^^^^^^^^ help: change this to: `existence_proof`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
   = note: `-D clippy::needless-borrow` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::needless_borrow)]`

Check failure on line 94 in crates/relayer-types/src/core/ics23_commitment/merkle.rs

View workflow job for this annotation

GitHub Actions / clippy-all-features

this expression creates a reference which is immediately dereferenced by the compiler 

error: this expression creates a reference which is immediately dereferenced by the compiler
  --> crates/relayer-types/src/core/ics23_commitment/merkle.rs:94:81
   |
94 |                         calculate_existence_root::<ics23::HostFunctionsManager>(&existence_proof)
   |                                                                                 ^^^^^^^^^^^^^^^^ help: change this to: `existence_proof`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
   = note: `-D clippy::needless-borrow` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::needless_borrow)]`

Check failure on line 94 in crates/relayer-types/src/core/ics23_commitment/merkle.rs

View workflow job for this annotation

GitHub Actions / clippy-all-features

this expression creates a reference which is immediately dereferenced by the compiler 

error: this expression creates a reference which is immediately dereferenced by the compiler
  --> crates/relayer-types/src/core/ics23_commitment/merkle.rs:94:81
   |
94 |                         calculate_existence_root::<ics23::HostFunctionsManager>(&existence_proof)
   |                                                                                 ^^^^^^^^^^^^^^^^ help: change this to: `existence_proof`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
   = note: `-D clippy::needless-borrow` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::needless_borrow)]`
.map_err(|_| Error::invalid_merkle_proof())?;

if !verify_membership::<ics23::HostFunctionsManager>(
Expand Down
Loading

0 comments on commit 4ab202e

Please sign in to comment.