Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8904 - FileuploadAdvanced beforefileupload #8987

Merged
merged 6 commits into from
Sep 3, 2024
Merged

8904 - FileuploadAdvanced beforefileupload #8987

merged 6 commits into from
Sep 3, 2024

Conversation

tjamesallen15
Copy link
Contributor

@tjamesallen15 tjamesallen15 commented Aug 27, 2024 •
edited
Loading

Explain the details for making this change. What existing problem does the pull request solve?

This pull request will add beforefileupload event in handleFileUpload method.

Related github/jira issue (required):
Closes #8904

Steps necessary to review your pull request (required):

Included in this Pull Request:

  • An e2e or functional test for the bug or feature.
  • A note to the change log.

@tjamesallen15 tjamesallen15 changed the title 8904 - FileuploadAdvanced beforefileupload 8904 - FileuploadAdvanced beforefileupload Aug 27, 2024
@tjamesallen15 tjamesallen15 marked this pull request as ready for review August 27, 2024 03:30
@tjamesallen15 tjamesallen15 requested a review from a team as a code owner August 27, 2024 03:30
glenlieorillo
glenlieorillo previously approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@glenlieorillo glenlieorillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

ericangeles
ericangeles reviewed Aug 27, 2024
View reviewed changes
Copy link
Contributor

@ericangeles ericangeles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Perhaps a test, @tjamesallen15?

jbrcna
jbrcna previously approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@jbrcna jbrcna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@tmcconechy tmcconechy dismissed stale reviews from jbrcna and glenlieorillo via 9048bcc August 27, 2024 14:55
@ericangeles
Copy link
Contributor

Please add this to NG as well, @tjamesallen15. Thanks! 🍌

@tmcconechy tmcconechy merged commit b790728 into main Sep 3, 2024
4 checks passed
@tmcconechy tmcconechy deleted the 8904-fileuploadadv-beforefileupload branch September 3, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmcconechy tmcconechy tmcconechy approved these changes

@ericangeles ericangeles ericangeles approved these changes

@jbrcna jbrcna jbrcna approved these changes

@glenlieorillo glenlieorillo glenlieorillo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FileuploadAdvanced: Need one 'beforefileupload' event in 'handleFileUpload' function
5 participants
@tjamesallen15 @ericangeles @tmcconechy @jbrcna @glenlieorillo