-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8767 - Add a callback function setting in notification #8941
Conversation
Tagging WIP, as I will add a test for this feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ericangeles looks good. maybe we can name the callback in case there is in the future other ones such as closeCallback
or clickCallback
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
before fix:
Screen.Recording.2024-08-05.at.1.02.46.PM.mov
after fix:
Screen.Recording.2024-08-05.at.1.02.26.PM.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explain the details for making this change. What existing problem does the pull request solve?
This PR adds a callback function setting that executes an action before the notification is closed.
In the example, a toast message is shown when the notification is closed.
Related github/jira issue (required):
Closes #8767
Steps necessary to review your pull request (required):
Included in this Pull Request: