Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8767 - Add a callback function setting in notification #8941

Merged
merged 4 commits into from
Aug 5, 2024

Conversation

ericangeles
Copy link
Contributor

Explain the details for making this change. What existing problem does the pull request solve?

This PR adds a callback function setting that executes an action before the notification is closed.

In the example, a toast message is shown when the notification is closed.

Related github/jira issue (required):

Closes #8767

Steps necessary to review your pull request (required):

Included in this Pull Request:

  • A test for the bug or feature.
  • A note to the change log.

@ericangeles
Copy link
Contributor Author

Tagging WIP, as I will add a test for this feature.

Copy link
Member

@tmcconechy tmcconechy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ericangeles looks good. maybe we can name the callback in case there is in the future other ones such as closeCallback or clickCallback?

Copy link
Contributor

@glenlieorillo glenlieorillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

before fix:

Screen.Recording.2024-08-05.at.1.02.46.PM.mov

after fix:

Screen.Recording.2024-08-05.at.1.02.26.PM.mov

Copy link
Contributor

@jbrcna jbrcna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@ericangeles ericangeles merged commit 56010a9 into main Aug 5, 2024
4 checks passed
@ericangeles ericangeles deleted the 8767-notification-callback branch August 5, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IdsNotification: Need an event listening method to the close button of the notification.
4 participants