Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8889 - Fix error on datagrid eror expanding rows #8891

Merged
merged 3 commits into from
Jul 19, 2024
Merged

8889 - Fix error on datagrid eror expanding rows #8891

merged 3 commits into from
Jul 19, 2024

Conversation

tmcconechy
Copy link
Member

Explain the details for making this change. What existing problem does the pull request solve?

Fixes a regression from #8832

Related github/jira issue (required):
Fixes #8889

Steps necessary to review your pull request (required):

Included in this Pull Request:

  • A note to the change log.

@tmcconechy tmcconechy requested a review from a team as a code owner July 10, 2024 15:58
@tmcconechy tmcconechy added the ready for qa Ready for QA to review label Jul 10, 2024
janahintal
janahintal requested changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@janahintal janahintal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Tim, I'm still having errors and UI issues after expanding rows and changing row size.

Test Data: screen-capture.webm
image

Regards,
Janah

jbrcna
jbrcna previously approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@jbrcna jbrcna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image image

glenlieorillo
glenlieorillo previously approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@glenlieorillo glenlieorillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No errors on my end.

Screen.Recording.2024-07-11.at.8.12.37.PM.mov

@tmcconechy
Copy link
Member Author

@janahintal i cant reproduce. Maybe you didnt have the right branch or something?

Can test it here as well https://8889-grid-error-enterprise.demo.design.infor.com/components/datagrid/test-expandable-row-frozen-columns.html

@tmcconechy tmcconechy dismissed stale reviews from glenlieorillo and jbrcna via 3b7d243 July 12, 2024 15:03
jbrcna
jbrcna approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@jbrcna jbrcna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

glenlieorillo
glenlieorillo approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@glenlieorillo glenlieorillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

janahintal
janahintal approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@janahintal janahintal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@tmcconechy tmcconechy merged commit f4c1824 into main Jul 19, 2024
4 checks passed
@tmcconechy tmcconechy deleted the 8889-grid-error branch July 19, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janahintal janahintal janahintal approved these changes

@jbrcna jbrcna jbrcna approved these changes

@glenlieorillo glenlieorillo glenlieorillo approved these changes

Assignees
No one assigned
Labels
ready for qa Ready for QA to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Datagrid: Errors when expanding rows with frozenColumns
4 participants
@tmcconechy @janahintal @jbrcna @glenlieorillo