Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8758 - Datagrid Focus With Button (Lookup) #8851

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

tjamesallen15
Copy link
Contributor

@tjamesallen15 tjamesallen15 commented Jun 26, 2024

Explain the details for making this change. What existing problem does the pull request solve?

This pull request will fix a bug where button gets focus always during editing of lookup field.

Related github/jira issue (required):
Closes #8758

Steps necessary to review your pull request (required):

Included in this Pull Request:

  • An e2e or functional test for the bug or feature.
  • A note to the change log.

@tjamesallen15 tjamesallen15 marked this pull request as ready for review June 26, 2024 08:50
@tjamesallen15 tjamesallen15 requested a review from a team as a code owner June 26, 2024 08:50
Copy link
Contributor

@glenlieorillo glenlieorillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now working as expected. However in RTL, the lookup button has an error upon clicking the cell. Refer to this issue: #8853.

Screen.Recording.2024-06-26.at.8.25.32.PM.mov

RTL

Screen.Recording.2024-06-26.at.8.27.18.PM.mov

@tmcconechy
Copy link
Member

tmcconechy commented Jun 26, 2024

@glenlieorillo i see you made a seperate issue. So i think that means this is good to go?

@tmcconechy tmcconechy added the ready for qa Ready for QA to review label Jun 26, 2024
@glenlieorillo
Copy link
Contributor

@glenlieorillo i see you made a seperate issue. So i think that means this is good to go?

Yes, @tmcconechy and I think the RTL icon issue is not related to this issue.

@tmcconechy tmcconechy merged commit 8aa6620 into main Jun 26, 2024
2 checks passed
@tmcconechy tmcconechy deleted the 8758-datagrid-focus-with-button branch June 26, 2024 13:52
@jbrcna
Copy link
Contributor

jbrcna commented Jun 27, 2024

working on main
Large GIF (1004x484)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for qa Ready for QA to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataGrid: The focus has automatically moved to lookup icon in datagrid.
4 participants