tests pass using bundler, once yaml and multi_json are properly required #20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running tests using
bundle exec rake rspec
, the require statement foryaml
is missing and causing tests to fail.The require statement for this library is contained within the
ConfigFile#read_yaml
method; similarly the require statement formulti_json
is contained inConfigFile#read_json
. Since both methods are top-level features, and are fully tested, these require statements should be moved into the main class loader. This will cause no dependency issues asyaml
has been a standard ruby library since 1.8.7 andmulti_json
is listed as a dependency in both the Gemfile and the gemspec.Break the silence, yo.