Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add telegraf.influxdata.com/global-tag-literal- #83

Merged
merged 1 commit into from
Feb 16, 2022

Conversation

mkmik
Copy link
Contributor

@mkmik mkmik commented Feb 16, 2022

Implements main form of the #82 proposal.

The implementation is quite quick&dirty; there are a few yaks to shave in order to make this more clean; in particular we should avoid fiddling with TOML as a string, but we should parse it and manipulate the AST or some intermediate representation. Unfortunately the TOML library we're using doesn't support marshaling back the AST back.

@telegraf-tiger telegraf-tiger bot added the feat label Feb 16, 2022
Copy link
Contributor

@wojciechka wojciechka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm wondering - why not just inject global tags section as raw configuration for telegraf? Is your concern that this has to be updated for other global tags?

@mkmik
Copy link
Contributor Author

mkmik commented Feb 16, 2022

LGTM, but I'm wondering - why not just inject global tags section as raw configuration for telegraf? Is your concern that this has to be updated for other global tags?

Yes. The class defined some global tags already

@wojciechka wojciechka merged commit d11dfaf into influxdata:master Feb 16, 2022
@mkmik mkmik deleted the global_tags branch February 16, 2022 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants