Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: rename metadata cache to distinct value cache #25775

Merged
merged 2 commits into from
Jan 10, 2025
Merged

refactor: rename metadata cache to distinct value cache #25775

merged 2 commits into from
Jan 10, 2025

Conversation

hiltontj
Copy link
Contributor

@hiltontj hiltontj commented Jan 9, 2025

Closes #25771

@hiltontj hiltontj added the v3 label Jan 9, 2025
@hiltontj hiltontj requested review from pauldix and mgattozzi January 9, 2025 20:18
@hiltontj hiltontj self-assigned this Jan 9, 2025
pauldix
pauldix approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@pauldix pauldix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skimmed through, I think it looks good

@hiltontj hiltontj marked this pull request as draft January 9, 2025 20:32
@hiltontj
Copy link
Contributor Author

hiltontj commented Jan 9, 2025

Flipped to draft so this doesn't get merged before #25766

@hiltontj hiltontj marked this pull request as ready for review January 10, 2025 13:40
@hiltontj hiltontj merged commit c71dafc into main Jan 10, 2025
13 checks passed
@hiltontj hiltontj deleted the hiltontj/distinct-v-cache branch January 10, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pauldix pauldix pauldix approved these changes

@mgattozzi mgattozzi Awaiting requested review from mgattozzi

Assignees

@hiltontj hiltontj

Labels
v3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename metadata cache to distinct values cache
2 participants
@hiltontj @pauldix