Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add DataToPoint utility to convert a custom struct to a write Point #394

Merged
merged 8 commits into from
Dec 1, 2023

Conversation

sranka
Copy link
Contributor

@sranka sranka commented Nov 28, 2023

Proposed Changes

This PR adds a new write.DataToPoint function that converts custom structures to write.Point, the code uses the tags/annotations from v3 client proposal to map structure fields to line protocol parts.

See also #389

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • Tests pass
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@sranka sranka marked this pull request as ready for review November 29, 2023 07:37
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c1da0c5) 92.72% compared to head (425a783) 92.94%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #394      +/-   ##
==========================================
+ Coverage   92.72%   92.94%   +0.21%     
==========================================
  Files          23       25       +2     
  Lines        2242     2310      +68     
==========================================
+ Hits         2079     2147      +68     
  Misses        123      123              
  Partials       40       40              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sranka sranka added this to the 2.14.5 milestone Dec 1, 2023
@sranka sranka merged commit cac777d into master Dec 1, 2023
2 checks passed
@sranka sranka deleted the backport_v3_writeData branch December 1, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants