Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release notes to GH releases #581

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

morganchristiansson
Copy link

@morganchristiansson morganchristiansson commented Jul 14, 2023

I noticed grafana/helm-charts repo has started to include changelog on releases and would really like to see the same in this repo!

Test release with changelog in my forked repo: https://github.com/morganchristiansson/influxdata-charts/releases/tag/telegraf-1.8.34

Changes copied from commit: grafana/helm-charts@98f267b

Also upgraded helm version - copied from this commit grafana/helm-charts@8d26baa

@morganchristiansson
Copy link
Author

helm 3.12.2 is out can maybe upgrade to latest. https://github.com/helm/helm/releases

I don't think helm upgraded is required tho, as you prefer.

Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No opposed, but can the cr.yaml file live under the .github/workflows directory as well?

@morganchristiansson
Copy link
Author

Isn't .github/workflows reserved for github workflows? doesn't seem like the right place.

There is already a ct.yaml (used by chart-testing) in root so this would go next to it.

Actually seems like cr.yaml in current directory is loaded by default so with: config: cr.yaml could be omitted.

@powersj
Copy link
Contributor

powersj commented Sep 7, 2023

Isn't .github/workflows reserved for github workflows? doesn't seem like the right place.

This file is referenced by the github workflow, hence why I thought it should be in there. And avoids adding a file to the root of the project. This is not something I would expect someone to run by hand right?

@morganchristiansson
Copy link
Author

chart-releaser runs great locally from CLI but you probably wouldn't except for debug/setup.

I'm not sure adding new .yaml files to .github/workflows will interfere with GitHub Actions? I'm happy to make the change if wanted tho...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants