Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Deduplicate env var #556

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

koooge
Copy link

@koooge koooge commented Apr 27, 2023

Hi there, telegraf-ds's daemonset has the duplicated env var HOSTIP.

...
      containers:
      - env:
        - name: HOSTIP
          valueFrom:
            fieldRef:
              apiVersion: v1
              fieldPath: status.hostIP
        - name: HOSTNAME
          valueFrom:
            fieldRef:
              apiVersion: v1
              fieldPath: spec.nodeName
        - name: HOSTIP
          valueFrom:
            fieldRef:
              apiVersion: v1
              fieldPath: status.hostIP
...

Copy link

@Bozz95 Bozz95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the right choice to remove this env var "HOSTIP" from the values.
Leaving the HOSTIP declaration only in the template file will enure that this helm installation will work regardless of the resolvable host ip within the containers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants