Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[telegraf] Add support for Cisco Model-Driven Telemetry (cisco_telemetry_mdt) #548

Merged
merged 6 commits into from
May 24, 2024

Conversation

hampusehh
Copy link
Contributor

@hampusehh hampusehh commented Mar 23, 2023

Automatically expose Cisco Model-Driven Telemetry (MDT) port as defined in config.inputs.

config:
  inputs:
    - cisco_telemetry_mdt:
         service_address: ":57000"
- [ ] CHANGELOG.md updated
- [x] Rebased/mergable
- [ ] Tests pass
- [x] Sign [CLA](https://influxdata.com/community/cla/) (if not already signed)

@hampusehh hampusehh changed the title Expose Cisco Model-Driven Telemetry (MDT) input plugin in service.yaml [telegraf] Expose Cisco Model-Driven Telemetry (MDT) input plugin in service.yaml Mar 23, 2023
@Saigut
Copy link

Saigut commented Nov 27, 2023

Hello, why not merge this pr?

@joelsvensson
Copy link

Can we try to bump the chart version similar to previous PRs?
https://github.com/influxdata/helm-charts/pull/390/files
https://github.com/influxdata/helm-charts/pull/401/files
Commit message like "feat: [telegraf] add support for cisco_telemetry_mdt input" and tests might run too.

Hopefully this can get it to a better state and bring attention to reviewers.
Current list of maintainers is outdated:
https://github.com/influxdata/helm-charts/blob/master/charts/telegraf/Chart.yaml#L18-L22

@hampusehh hampusehh changed the title [telegraf] Expose Cisco Model-Driven Telemetry (MDT) input plugin in service.yaml [telegraf] Add support for Cisco Model-Driven Telemetry (cisco_telemetry_mdt) May 14, 2024
@hampusehh
Copy link
Contributor Author

@gitirabassi, is it possible for you to look at this? Or help us get attention here?
(I ping you as you are one of the maintainers of the Chart.yaml)

@joelsvensson
Copy link

@gitirabassi, is it possible for you to look at this? Or help us get attention here? (I ping you as you are one of the maintainers of the Chart.yaml)

Maybe @powersj can assist?

Copy link

@hamps-contrib hamps-contrib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@hamps-contrib hamps-contrib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; after rebase

@powersj powersj merged commit c71efaa into influxdata:master May 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants