feat: add initcontainers, sidecars and extra k8s objects to telegraf charts #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds multiple functioanlities to the telegraf and telegraf-ds helm charts.
For both charts:
1- init containers are added with possiblites to have multiple not only one. This PR also provides it but it can do only one container and it's not flexible.
2- side car containers are added
3- extra k8s objects
For telegraf-ds:
1- ports are customizable for the daemonset
2- renamed the socket instead of docker to runtime. Note I didn't change the default to containerd so I don't break an existing installations.