-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #417 Add serviceMonitor template for the telegraf chart #510
base: master
Are you sure you want to change the base?
Fix #417 Add serviceMonitor template for the telegraf chart #510
Conversation
Signed-off-by: Efrat19 <[email protected]>
Signed-off-by: Efrat19 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please bump chart version.
…af_servicemonitor
Signed-off-by: Efrat19 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hey is there anything else still needed to be done here? @tomklapka @alespour |
…af_servicemonitor
Signed-off-by: Efrat Levitan <[email protected]>
Checks failed with Error: ServiceMonitor.monitoring.coreos.com "telegraf-1xv72y61rr" is invalid: spec.endpoints.port: Invalid value: "integer": spec.endpoints.port in body must be of type string: "integer". Please fix it. |
fixed |
@Efrat19 please rebase your branch to master and bump up the telegraf chart version (1.8.23 -> 1.8.24) Thank you. |
Signed-off-by: Efrat19 [email protected]
addressing #417